lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 09 Sep 2017 15:10:31 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Harsha Sharma <harshasharmaiitr@...il.com>
Cc:     devel@...verdev.osuosl.org, outreachy-kernel@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Change foo* bar to foo *bar

On Sat, 2017-09-09 at 18:50 +0200, Greg KH wrote:
> On Sat, Sep 09, 2017 at 10:09:37PM +0530, Harsha Sharma wrote:
> > This coding style (foo *bar) is more common for the kernel code.
> 
> You also did something else in this patch that you did not mention here,
> which is not ok :(

what is that?

> Remember, only one type of thing per patch.

Seemed like only one thing to me.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ