lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 09 Sep 2017 22:47:14 +0100 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Sakari Ailus" <sakari.ailus@...ux.intel.com>, "Hans Verkuil" <hans.verkuil@...co.com>, "Christophe JAILLET" <christophe.jaillet@...adoo.fr>, "Mauro Carvalho Chehab" <mchehab@...pensource.com> Subject: [PATCH 3.16 122/233] [media] vb2: Fix an off by one error in 'vb2_plane_vaddr' 3.16.48-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Christophe JAILLET <christophe.jaillet@...adoo.fr> commit 5ebb6dd36c9f5fb37b1077b393c254d70a14cb46 upstream. We should ensure that 'plane_no' is '< vb->num_planes' as done in 'vb2_plane_cookie' just a few lines below. Fixes: e23ccc0ad925 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework") Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com> Signed-off-by: Hans Verkuil <hans.verkuil@...co.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@...pensource.com> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -1107,7 +1107,7 @@ EXPORT_SYMBOL_GPL(vb2_create_bufs); */ void *vb2_plane_vaddr(struct vb2_buffer *vb, unsigned int plane_no) { - if (plane_no > vb->num_planes || !vb->planes[plane_no].mem_priv) + if (plane_no >= vb->num_planes || !vb->planes[plane_no].mem_priv) return NULL; return call_ptr_memop(vb, vaddr, vb->planes[plane_no].mem_priv);
Powered by blists - more mailing lists