linux-kernel - Re: [PATCH] iio: adc: dln2-adc: initialize local struct before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170910163058.0eefc6ae@archlinux>
Date:   Sun, 10 Sep 2017 16:30:58 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Martin Kepplinger <martink@...teo.de>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: dln2-adc: initialize local struct before
 using it

On Sun, 10 Sep 2017 14:45:01 +0200
Martin Kepplinger <martink@...teo.de> wrote:

> struct data is defined and declared locally. Initiliazation has to be done
> manually, so let's add that.
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>
> ---
> 
> This is more of a question actually! Did you have in mind that data is
> not initialized here? If so, please drop this patch. This is just in case
> you implicitely expected data to be zero.
> 

I don't think it matters as the whole structure is filled by the later
code anyway..  Am I missing a path where it isn't?

Jonathan

> 
>  drivers/iio/adc/dln2-adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c
> index ab8d6aed5085..452330075b67 100644
> --- a/drivers/iio/adc/dln2-adc.c
> +++ b/drivers/iio/adc/dln2-adc.c
> @@ -489,7 +489,7 @@ static irqreturn_t dln2_adc_trigger_h(int irq, void *p)
>  	struct {
>  		__le16 values[DLN2_ADC_MAX_CHANNELS];
>  		int64_t timestamp_space;
> -	} data;
> +	} data = { 0 };
>  	struct dln2_adc_get_all_vals dev_data;
>  	struct dln2_adc *dln2 = iio_priv(indio_dev);
>  	const struct dln2_adc_demux_table *t;