linux-kernel - Re: [PATCH] checkpatch: Fix ignoring cover-letter logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Sep 2017 11:08:15 -0700
From:   Joe Perches <joe@...ches.com>
To:     Stafford Horne <shorne@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Fix ignoring cover-letter logic

On Sat, 2017-09-09 at 18:04 +0900, Stafford Horne wrote:
> Currently running checkpatch on a directory with a cover-letter.patch
> file reports the following error:
> 
>   -----------------------------------------
>   patches/smp-v2/v2-0000-cover-letter.patch
>   -----------------------------------------
> 
>   ERROR: Does not appear to be a unified-diff format patch
> 
> The logic to suppress the unified-diff check for cover letters is there
> but is checking $file instead of $filename.  Fix the variable to use the
> correct one.
> 
> Signed-off-by: Stafford Horne <shorne@...il.com>

Acked-by: Joe Perches <joe@...ches.com>

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6365,7 +6365,7 @@ sub process {
>  		exit(0);
>  	}
>  
> -	if (!$is_patch && $file !~ /cover-letter\.patch$/) {
> +	if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
>  		ERROR("NOT_UNIFIED_DIFF",
>  		      "Does not appear to be a unified-diff format patch\n");
>  	}