linux-kernel - Re: [Outreachy kernel] [PATCH 03/10] staging: rtl8723bs: Add spaces around '?', '==', '||', '!='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Sep 2017 22:01:12 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Harsha Sharma <harshasharmaiitr@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 03/10] staging: rtl8723bs: Add spaces
 around '?', '==', '||', '!='



On Sun, 10 Sep 2017, Harsha Sharma wrote:

> Use spaces around most binary operators
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@...il.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 18f0ac2..5ceccd7 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -1140,7 +1140,7 @@ static int pm_netdev_open(struct net_device *pnetdev, u8 bnormal)
>  		}
>  	}
>  	else
> -		status =  (_SUCCESS == ips_netdrv_open(padapter))?(0):(-1);
> +		status =  (_SUCCESS == ips_netdrv_open(padapter)) ? (0) : (-1);
>
>  	return status;
>  }
> @@ -1262,7 +1262,7 @@ void rtw_dev_unload(struct adapter *padapter)
>  			rtw_btcoex_IpsNotify(padapter, pwrctl->ips_mode_req);
>  #ifdef CONFIG_WOWLAN
>  			if (pwrctl->bSupportRemoteWakeup == true &&
> -				pwrctl->wowlan_mode ==true) {
> +				pwrctl->wowlan_mode == true) {
>  				DBG_871X_LEVEL(_drv_always_, "%s bSupportRemoteWakeup ==true  do not run rtw_hal_deinit()\n", __func__);
>  			}
>  			else
> @@ -1524,7 +1524,7 @@ int rtw_suspend_common(struct adapter *padapter)
>  	while (pwrpriv->bips_processing == true)
>  		msleep(1);
>
> -	if ((!padapter->bup) || (padapter->bDriverStopped)||(padapter->bSurpriseRemoved))
> +	if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved))
>  	{
>  		DBG_871X("%s bup =%d bDriverStopped =%d bSurpriseRemoved = %d\n", __func__
>  			, padapter->bup, padapter->bDriverStopped, padapter->bSurpriseRemoved);
> @@ -1671,7 +1671,7 @@ int rtw_resume_process_wow(struct adapter *padapter)
>  		DBG_871X_LEVEL(_drv_always_, "%s: ### ERROR ### wowlan_mode =%d\n", __func__, pwrpriv->wowlan_mode);
>  	}
>
> -	if (padapter->pid[1]!= 0) {
> +	if (padapter->pid[1] != 0) {
>  		DBG_871X("pid[1]:%d\n", padapter->pid[1]);
>  		rtw_signal_process(padapter->pid[1], SIGUSR2);
>  	}
> @@ -1774,7 +1774,7 @@ int rtw_resume_process_ap_wow(struct adapter *padapter)
>  			rtw_netif_wake_queue(pnetdev);
>  	}
>
> -	if (padapter->pid[1]!= 0) {
> +	if (padapter->pid[1] != 0) {
>  		DBG_871X("pid[1]:%d\n", padapter->pid[1]);
>  		rtw_signal_process(padapter->pid[1], SIGUSR2);
>  	}
> @@ -1842,7 +1842,7 @@ static int rtw_resume_process_normal(struct adapter *padapter)
>  	netif_device_attach(pnetdev);
>  	netif_carrier_on(pnetdev);
>
> -	if (padapter->pid[1]!= 0) {
> +	if (padapter->pid[1] != 0) {
>  		DBG_871X("pid[1]:%d\n", padapter->pid[1]);
>  		rtw_signal_process(padapter->pid[1], SIGUSR2);
>  	}
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/be22d7c63780098571fec9d490b1a83039ddbb75.1505052882.git.harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>