linux-kernel - Re: [PATCH] btrfs: tests: Fix a memory leak in error handling path in 'run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72f72ca7-8c48-5501-7835-ac619801cd34@gmx.com>
Date:   Sun, 10 Sep 2017 19:56:17 +0800
From:   Qu Wenruo <quwenruo.btrfs@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>, clm@...com,
        jbacik@...com, dsterba@...e.com, nborisov@...e.com, jeffm@...e.com,
        osandov@...com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] btrfs: tests: Fix a memory leak in error handling path in
 'run_test()'



On 2017年09月10日 19:19, Christophe JAILLET wrote:
> If 'btrfs_alloc_path()' fails, we must free the resourses already
> allocated, as done in the other error handling paths in this function.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Qu Wenruo <quwenruo.btrfs@....com>

BTW, I also checked all btrfs_alloc_path() in self tests, not such leak 
remaining.

Thanks,
Qu
> ---
>   fs/btrfs/tests/free-space-tree-tests.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tests/free-space-tree-tests.c b/fs/btrfs/tests/free-space-tree-tests.c
> index 1458bb0ea124..8444a018cca2 100644
> --- a/fs/btrfs/tests/free-space-tree-tests.c
> +++ b/fs/btrfs/tests/free-space-tree-tests.c
> @@ -500,7 +500,8 @@ static int run_test(test_func_t test_func, int bitmaps, u32 sectorsize,
>   	path = btrfs_alloc_path();
>   	if (!path) {
>   		test_msg("Couldn't allocate path\n");
> -		return -ENOMEM;
> +		ret = -ENOMEM;
> +		goto out;
>   	}
>   
>   	ret = add_block_group_free_space(&trans, root->fs_info, cache);
>