linux-kernel - Re: [PATCH] sysrq : fix Show Regs call trace on ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5dd5bb30-15af-ab44-8b56-57c3c1d53bc4@windriver.com>
Date:   Mon, 11 Sep 2017 17:55:05 +0800
From:   Jibin Xu <jibin.xu@...driver.com>
To:     Jiri Slaby <jslaby@...e.cz>, <gregkh@...uxfoundation.org>
CC:     <rmk+kernel@...linux.org.uk>, <mingo@...e.hu>,
        <linux-arm-kernel@...ts.infradead.org>, <riel@...hat.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysrq : fix Show Regs call trace on ARM

Hi,Jiri:

get_irq_regs() in the softirq context return NULL.

thanks,
Jibin Xu

On 2017年09月11日 13:24, Jiri Slaby wrote:
> On 09/11/2017, 05:11 AM, Jibin Xu wrote:
> ...
>> --- a/drivers/tty/sysrq.c
>> +++ b/drivers/tty/sysrq.c
>> @@ -245,8 +245,10 @@ static void sysrq_handle_showallcpus(int key)
>>   	 * architecture has no support for it:
>>   	 */
>>   	if (!trigger_all_cpu_backtrace()) {
>> -		struct pt_regs *regs = get_irq_regs();
>> +		struct pt_regs *regs = NULL;
>>   
>> +		if (in_irq())
>> +			regs = get_irq_regs();
> Maybe a stupid question: how does get_irq_regs() behave in the softirq
> context? I.e. what about s/in_irq/in_interrupt/?
>
> thanks,