linux-kernel - Re: [PATCH] extcon: make extcon_info static const, fixes warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <59B5DC19.4020805@samsung.com>
Date:   Mon, 11 Sep 2017 09:43:05 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Colin King <colin.king@...onical.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: make extcon_info static const, fixes warning

On 2017년 09월 10일 01:51, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The array extcon_info is read only, local to the source and does not
> need to be in global scope, so make it static const.
> 
> Cleans up sparse warning:
> symbol 'extcon_info' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 35e9fb885486..cb38c2747684 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -36,7 +36,7 @@
>  
>  #define SUPPORTED_CABLE_MAX	32
>  
> -struct __extcon_info {
> +static const struct __extcon_info {
>  	unsigned int type;
>  	unsigned int id;
>  	const char *name;
> 

Applied it for v4.15. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics