linux-kernel - Re: [PATCH] perf: support running perf binaries with a dash in their name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1605058.Qn1Snd44fD@milian-kdab2>
Date:   Mon, 11 Sep 2017 17:16:11 +0200
From:   Milian Wolff <milian.wolff@...b.com>
To:     Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:     David Ahern <dsahern@...il.com>, acme@...nel.org,
        Linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Yao Jin <yao.jin@...ux.intel.com>
Subject: Re: [PATCH] perf: support running perf binaries with a dash in their name

On Monday, September 11, 2017 4:33:12 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 11, 2017 at 07:08:18AM -0700, David Ahern escreveu:
> > On 9/11/17 4:14 AM, Milian Wolff wrote:
> > > Previously the part behind "perf-" was interpreted as an internal
> > > perf command. If the suffix could not be handled, the execution
> 
> <SNIP>
> 
> > > --- a/tools/perf/perf.c
> > > -		fprintf(stderr, "cannot handle %s internally", cmd);
> > > -		goto out;
> > > +		// if the command is handled, the above function does not return
> > > +		// undo changes and fall through in such a case
> > 
> > Those should be /* */ not //
> > 
> > > +		cmd -= 5;
> > > +		argv[0] = cmd;
> > > 
> > >  	}
> > >  	if (strstarts(cmd, "trace")) {
> > >  
> > >  #ifdef HAVE_LIBAUDIT_SUPPORT
> > 
> > other than that LGTM and long over due.
> > 
> > Acked-by: David Ahern <dsahern@...il.com>
> 
> We got those from git, agreed it should go, thanks for the Acked-by,
> always welcome!

Arnaldo, do you want me to fixup the commit, or can you handle it?

Thanks for the review guys

-- 
Milian Wolff | milian.wolff@...b.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
Download attachment "smime.p7s" of type "application/pkcs7-signature" (3826 bytes)