linux-kernel - Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170911164750.GA2607@obsidianresearch.com>
Date:   Mon, 11 Sep 2017 10:47:50 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Thiebaud Weksteen <tweek@...gle.com>
Cc:     linux-efi@...r.kernel.org, ard.biesheuvel@...aro.org,
        matt@...eblueprint.co.uk, linux-kernel@...r.kernel.org,
        mjg59@...gle.com, tpmdd-devel@...ts.sourceforge.net,
        peterhuewe@....de, jarkko.sakkinen@...ux.intel.com,
        tpmdd@...horst.net
Subject: Re: [PATCH v2 3/3] tpm: parse TPM event logs based on EFI table

On Mon, Sep 11, 2017 at 12:00:22PM +0200, Thiebaud Weksteen wrote:
  
>  	chip->bin_log_seqops.chip = chip;
> -	if (chip->flags & TPM_CHIP_FLAG_TPM2)
> +
> +	if (log_version == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 ||
> +	    (!log_version && (chip->flags & TPM_CHIP_FLAG_TPM2)))
>  		chip->bin_log_seqops.seqops =
>  			&tpm2_binary_b_measurements_seqops;

Lets have all the read_log_* versions return the postitive log_version
and get rid of the chip->flags check here.

ie Doesn't ACPI always return the TPM 1 version?

Jason