linux-kernel - Re: [PATCH] btrfs: Clean up dead code in root-tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170911170618.GA14538@twin.jikos.cz>
Date:   Mon, 11 Sep 2017 19:06:18 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Christos Gkekas <chris.gekas@...il.com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Clean up dead code in root-tree

On Sat, Sep 09, 2017 at 03:29:34PM +0100, Christos Gkekas wrote:
> The value of variable 'can_recover' is never used after being set, thus
> it should be removed.

Seems it has never been used since introduction in commit
68a7342c51c95042 .

Reviewed-by: David Sterba <dsterba@...e.com>
> 
> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>
> ---
>  fs/btrfs/root-tree.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
> index 95bcc3c..3338407 100644
> --- a/fs/btrfs/root-tree.c
> +++ b/fs/btrfs/root-tree.c
> @@ -226,10 +226,6 @@ int btrfs_find_orphan_roots(struct btrfs_fs_info *fs_info)
>  	struct btrfs_root *root;
>  	int err = 0;
>  	int ret;
> -	bool can_recover = true;
> -
> -	if (sb_rdonly(fs_info->sb))
> -		can_recover = false;
>  
>  	path = btrfs_alloc_path();
>  	if (!path)
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html