linux-kernel - Re: [PATCH] binder: fix memory corruption in binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Sep 2017 10:24:49 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Amit Pundir <amit.pundir@...aro.org>
Cc:     Todd Kjos <tkjos@...gle.com>, Todd Kjos <tkjos@...roid.com>,
        Arve Hjønnevåg <arve@...roid.com>,
        "open list:ANDROID DRIVERS" <devel@...verdev.osuosl.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Martijn Coenen <maco@...gle.com>,
        Xu Yiping <xuyiping@...ilicon.com>, gengyanping@...ilicon.com,
        shiwanglai@...ilicon.com, John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH] binder: fix memory corruption in binder_transaction
 binder

On Mon, Sep 11, 2017 at 10:25:14PM +0530, Amit Pundir wrote:
> Hi Todd,
> 
> On 11 September 2017 at 21:10, Todd Kjos <tkjos@...gle.com> wrote:
> > (resend in plain-text mode -- sorry about that)
> >
> > Amit,
> >
> > Are you sure this patch is the culprit? That is pretty surprising
> > since this change can only be hit in a uncommon case (the target node
> > is valid when we start creating the transaction, but dead when we
> > check right before sending it) so it is unlikely to be hit during a
> > normal boot. It also fixes a corruption -- so if you were actually
> > hitting the case, it would likely have caused issues before and not
> > now. Take a look at it and see if you think it is really possible.
> >
> > I just booted hikey to Android with this patch 10 times in a row with
> > no issues (used hikey-linaro 4.9 kernel which has this patch).
> 
> Sorry for not being clear enough in the bug report. android-4.9 is
> fine, I see this issue on linux mainline tree with this patch.

What exact kernel release?  A number of binder fixes have recently
landed in the stable trees, and in Linus's tree.

thanks,

greg k-h