linux-kernel - Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Remove unused variable monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOtvUMfoK3JxwYqXOXo8UEvSM5FPw+_RR2Evy9BfDKEf-StLDA@mail.gmail.com>
Date:   Mon, 11 Sep 2017 21:10:28 +0300
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     Sean Paul <seanpaul@...omium.org>
Cc:     Srishti Sharma <srishtishar@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Remove unused
 variable monitor_lock

On Mon, Sep 11, 2017 at 7:36 PM, Sean Paul <seanpaul@...omium.org> wrote:
> On Mon, Sep 11, 2017 at 12:28 PM, Srishti Sharma <srishtishar@...il.com> wrote:
>> Remove the variable monitor_lock as it is not used anywhere.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
>
> Reviewed-by: Sean Paul <seanpaul@...omium.org>

That variable is a left-over I've missed when I deleted an implementation of
something that was almost, but not quite, entirely unlike perf and is
no longer used.

So, assuming it compiles fine (I'm away from my build infrastructure
at the moment):

Acked-by: Gilad Ben-Yossef <gilad@...yossef.com>

Thank you,
Gilad

>
>> ---
>> Changes in v2:
>>  -The variable that was not to be declared as volatile can be
>>   eliminated as it is not being used anywhere.
>>
>>  drivers/staging/ccree/ssi_request_mgr.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
>> index e5c2f92..b94a91f 100644
>> --- a/drivers/staging/ccree/ssi_request_mgr.c
>> +++ b/drivers/staging/ccree/ssi_request_mgr.c
>> @@ -49,7 +49,6 @@ struct ssi_request_mgr_handle {
>>         dma_addr_t dummy_comp_buff_dma;
>>         struct cc_hw_desc monitor_desc;
>>
>> -       volatile unsigned long monitor_lock;
>>  #ifdef COMP_IN_WQ
>>         struct workqueue_struct *workq;
>>         struct delayed_work compwork;
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
>> To post to this group, send email to outreachy-kernel@...glegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505147317-13411-1-git-send-email-srishtishar%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.



-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru