linux-kernel - Re: [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170912002528.615d0e40@alans-desktop>
Date:   Tue, 12 Sep 2017 00:25:28 +0100
From:   Alan Cox <alan@...yncelyn.cymru>
To:     Vincent Hervieux <vincent.hervieux@...il.com>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        sakari.ailus@...ux.intel.com, hans.verkuil@...co.com,
        rvarsha016@...il.com, dan.carpenter@...cle.com,
        fengguang.wu@...el.com, daeseok.youn@...il.com,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

On Mon, 11 Sep 2017 20:49:27 +0200
Vincent Hervieux <vincent.hervieux@...il.com> wrote:

> Currently atomisp module supports Intel's Baytrail SoC and contains
> some compilation switches to support Intel's Cherrytrail SoC instead.
> The patchset aims to :
> - 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu.
> - 2/2: fix compilation errors for ATOMISP2401.
> I'm not so confident with patch 2/2, as it is only working around the non declared functions by using the 2400 path. As I couln't find any declaration/definition for the ISP2401 missing functions...So any help would be appreciated.
> Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl as explained in TODO step 6.

Please don't. Right now we know what work is to be done and tested.

Alan