linux-kernel - Re: [PATCH] media: v4l2-pci-skeleton: Fix error handling path in 'skeleton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b00047e-ce61-bd72-9bf2-c248a87eb013@cisco.com>
Date:   Mon, 11 Sep 2017 09:21:25 +0200
From:   Hans Verkuil <hansverk@...co.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        mchehab@...nel.org, hans.verkuil@...co.com, Julia.Lawall@...6.fr
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] media: v4l2-pci-skeleton: Fix error handling path in
 'skeleton_probe()'

On 09/10/2017 01:53 PM, Christophe JAILLET wrote:
> If this memory allocation fails, we must release some resources, as
> already done in the code below and above.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Please repost and add the linux-media mailinglist to the CC list. That way it ends up
in our patchwork system and it won't be forgotten.

Regards,

	Hans

> ---
>  samples/v4l/v4l2-pci-skeleton.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/v4l/v4l2-pci-skeleton.c b/samples/v4l/v4l2-pci-skeleton.c
> index 483e9bca9444..f520e3aef9c6 100644
> --- a/samples/v4l/v4l2-pci-skeleton.c
> +++ b/samples/v4l/v4l2-pci-skeleton.c
> @@ -772,8 +772,10 @@ static int skeleton_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	/* Allocate a new instance */
>  	skel = devm_kzalloc(&pdev->dev, sizeof(struct skeleton), GFP_KERNEL);
> -	if (!skel)
> -		return -ENOMEM;
> +	if (!skel) {
> +		ret = -ENOMEM;
> +		goto disable_pci;
> +	}
>  
>  	/* Allocate the interrupt */
>  	ret = devm_request_irq(&pdev->dev, pdev->irq,
>