linux-kernel - Re: [PATCH] procfs: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170912074348.iw5u62527rxr3pyl@dhcp22.suse.cz>
Date:   Tue, 12 Sep 2017 09:43:48 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Vegard Nossum <vegard.nossum@...cle.com>,
        Andy Lutomirski <luto@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] procfs: remove unused variable

On Mon 11-09-17 22:02:16, Arnd Bergmann wrote:
> in NOMMU configurations, we get a warning about a variable
> that has become unused:
> 
> fs/proc/task_nommu.c: In function 'nommu_vma_show':
> fs/proc/task_nommu.c:148:28: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 01a949ccf3b9 ("fs, proc: remove priv argument from is_stack")

this sha doesn't exist in Linus tree. I guess it comes from linux-next.
The merged commit is 1240ea0dc3bb ("fs, proc: remove priv argument from
is_stack")

Other than that
Acked-by: Michal Hocko <mhocko@...e.com>

Thanks for catching this and the fix!

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  fs/proc/task_nommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c
> index dea90b566a6e..b00b766098fa 100644
> --- a/fs/proc/task_nommu.c
> +++ b/fs/proc/task_nommu.c
> @@ -145,7 +145,6 @@ static int nommu_vma_show(struct seq_file *m, struct vm_area_struct *vma,
>  			  int is_pid)
>  {
>  	struct mm_struct *mm = vma->vm_mm;
> -	struct proc_maps_private *priv = m->private;
>  	unsigned long ino = 0;
>  	struct file *file;
>  	dev_t dev = 0;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs