linux-kernel - Re: [PATCH] f2fs-tools: move_curseg_info only if check_curseg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <150fcefc-416e-7132-752a-c37f7ad88bf3@huawei.com>
Date:   Tue, 12 Sep 2017 09:19:19 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Yunlong Song <yunlong.song@...wei.com>, <jaegeuk@...nel.org>,
        <chao@...nel.org>, <yunlong.song@...oud.com>
CC:     <miaoxie@...wei.com>, <bintian.wang@...wei.com>,
        <linux-fsdevel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] f2fs-tools: move_curseg_info only if check_curseg_offset
 fails

On 2017/9/11 0:20, Yunlong Song wrote:
> Current design will lose recovery process when check_curseg_offset is OK.
> 
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

> ---
>  fsck/fsck.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fsck/fsck.c b/fsck/fsck.c
> index cb341ba..56a47be 100644
> --- a/fsck/fsck.c
> +++ b/fsck/fsck.c
> @@ -2026,9 +2026,11 @@ int fsck_verify(struct f2fs_sb_info *sbi)
>  			fix_hard_links(sbi);
>  			fix_nat_entries(sbi);
>  			rewrite_sit_area_bitmap(sbi);
> -			move_curseg_info(sbi, SM_I(sbi)->main_blkaddr);
> -			write_curseg_info(sbi);
> -			flush_curseg_sit_entries(sbi);
> +			if (check_curseg_offset(sbi)) {
> +				move_curseg_info(sbi, SM_I(sbi)->main_blkaddr);
> +				write_curseg_info(sbi);
> +				flush_curseg_sit_entries(sbi);
> +			}
>  			fix_checkpoint(sbi);
>  		} else if (is_set_ckpt_flags(cp, CP_FSCK_FLAG)) {
>  			write_checkpoint(sbi);
>