linux-kernel - [PATCH] backlight: s6e63m0: make const arrays static, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2017 12:45:45 +0100
From:   Colin King <colin.king@...onical.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-fbdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] backlight: s6e63m0: make const arrays static, reduces object code size

From: Colin Ian King <colin.king@...onical.com>

Don't populate const arrays on the stack, instead make them
static.  Makes the object code smaller by nearly 400 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  15164	   6336	      0	  21500	   53fc	drivers/video/backlight/s6e63m0.o

After:
   text	   data	    bss	    dec	    hex	filename
  14669	   6432	      0	  21101	   526d	drivers/video/backlight/s6e63m0.o

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/video/backlight/s6e63m0.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index 3c4a22a3063a..965c660b2f6b 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -446,7 +446,7 @@ static int s6e63m0_gamma_ctl(struct s6e63m0 *lcd, int gamma)
 static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
 {
 	int ret, i;
-	const unsigned short *init_seq[] = {
+	static const unsigned short *init_seq[] = {
 		seq_panel_condition_set,
 		seq_display_condition_set,
 		seq_gamma_setting,
@@ -467,7 +467,7 @@ static int s6e63m0_ldi_init(struct s6e63m0 *lcd)
 static int s6e63m0_ldi_enable(struct s6e63m0 *lcd)
 {
 	int ret = 0, i;
-	const unsigned short *enable_seq[] = {
+	static const unsigned short *enable_seq[] = {
 		seq_stand_by_off,
 		seq_display_on,
 	};
-- 
2.14.1