linux-kernel - Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2017 14:10:16 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Helge Deller <deller@....de>
Cc:     linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [PATCH 02/14] um: Use %pS printk format for symbols from direct
 addresses

On Wed 2017-09-06 22:27:49, Helge Deller wrote:
> Use the %pS printk format for printing symbols from direct addresses.
> In usermode-linux there is actually no difference between %pS and %pF, but for
> consistency throughout the kernel fix the wrong usage here too.
> 
> Signed-off-by: Helge Deller <deller@....de>
> Cc: Jeff Dike <jdike@...toit.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: user-mode-linux-devel@...ts.sourceforge.net
> ---
>  arch/um/kernel/sysrq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
> index 6b995e8..05585ee 100644
> --- a/arch/um/kernel/sysrq.c
> +++ b/arch/um/kernel/sysrq.c
> @@ -20,7 +20,7 @@
>  
>  static void _print_addr(void *data, unsigned long address, int reliable)
>  {
> -	pr_info(" [<%08lx>] %s%pF\n", address, reliable ? "" : "? ",
> +	pr_info(" [<%08lx>] %s%pS\n", address, reliable ? "" : "? ",
>  		(void *)address);

This seems to be used to print addresses from the stack.
IMHO, we should use %pB here.

Best Regards,
Petr