linux-kernel - Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2017 15:10:54 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "jpinto@...opsys.com" <jpinto@...opsys.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "vinholikatti@...il.com" <vinholikatti@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces
 object code size

On Tue, 2017-09-12 at 12:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate const arrays on the stack, instead make them
> static.  Makes the object code smaller by over 740 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    3840	    208	      0	   4048	    fd0	drivers/scsi/ufs/tc-dwc-g210.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    2679	    624	      0	   3303	    ce7	drivers/scsi/ufs/tc-dwc-g210.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Please CC the most active contributors of a driver when submitting a driver
patch. Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>