linux-kernel - Re: [media] s5p-mfc: Adjust a null pointer check in four functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2017 19:41:28 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        Andrzej Hajda <a.hajda@...sung.com>,
        Jeongtae Park <jtp.park@...sung.com>,
        Kamil Debski <kamil@...as.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions

On 09/12/2017 05:00 PM, SF Markus Elfring wrote:
>>> * Do you care to preserve an information like the author date?
>> In this case not, but actually the Date line is not an issue.
> Thanks for your information.
> 
> It seems then that you quoted a line too much.
>  
>> Anyway the patch is malformed, …
 >
> I have got doubts for this view because the file was automatically generated
> by the command “git format-patch” also for the discussed three update steps.

Generating patch is only part of the story, it seems the patch is not sent
properly and tags which should be in SMTP header end up in the message
body. I think there would not be such issues if you have used git format-patch
+ git send-email.

I normally do amend things like this while applying, I will do that this time 
as well. It's already too much time wasted for such a dubious patch.

-- 
Thanks,
Sylwester