linux-kernel - Re: Splitting led drivers to subdirectories?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72bc03c4-90d8-0f82-42b5-172022fb6a8b@gmail.com>
Date:   Tue, 12 Sep 2017 21:11:07 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        kernel list <linux-kernel@...r.kernel.org>
Subject: Re: Splitting led drivers to subdirectories?

Hi,

On 09/12/2017 02:54 PM, Pavel Machek wrote:
> Hi!
> 
> Is it time to start splitting drivers into subdirectories?
> 
> I'd quite like to see drivers/leds/i2c/ and drivers/leds/flash/ . That
> way it is easier to look at related drivers for inspiration...

These categorization would be inconsistent - i2c is a bus, and
flash is a LED function. Moreover, not all devices are driven through
buses, some of them via gpio, MMIO or even as2cwire like in case of
leds-aat1290. Do we want to split the drivers like that? It would
generate only unnecessary noise IMHO.

We could go for splitting drivers to LED and LED flash class,
but the former is just a subset of the latter, so it would be
also not accurate.

Effectively I propose to apply the "leave well alone" rule here :-)

-- 
Best regards,
Jacek Anaszewski