linux-kernel - Re: Patch 0727d35de ("Make initramfs honor CONFIG_DEVTMPFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170912004243.GA3963@jagdpanzerIV.localdomain>
Date:   Tue, 12 Sep 2017 09:42:43 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Rob Landley <rob@...dley.net>,
        Michael Ellerman <mpe@...erman.id.au>,
        Yury Norov <ynorov@...iumnetworks.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Prarit Bhargava <prarit@...hat.com>,
        Yang Shi <yang.shi@...aro.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Kees Cook <keescook@...omium.org>,
        Emese Revfy <re.emese@...il.com>,
        Fabian Frederick <fabf@...net.be>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: Patch 0727d35de ("Make initramfs honor CONFIG_DEVTMPFS_MOUNT")
 breaks boot

On (09/11/17 13:45), Petr Mladek wrote:
[..]
> > Except for the second printk line: If you boot with rdinit=/bin/hush
> > then the first time you mount -t devtmpfs /dev /dev after boot (with
> > CONFIG_DEVTMPFS_MOUNT already having mounted it), you get the 0 return
> > value but the last printk() doesn't output? The second and later times
> > you repeat it, both printk() lines are output.
> > 
> > What's up with printk?
> > 
> > (I added the second printk because the _first_ one wasn't outputting
> > that first time. Something is happening to flush the printk() queue
> > instead of writing it out?
> Maybe, we could setup the timer via an irq_work. We already use
> this trick for flushing deferred printk and waking klogd.
> It is not nice but it would be easier than the previous mess.

printk() and printf() have similar behaviour here. both flush on \n.
so let's keep it the way it is?

	-ss