linux-kernel - Re: [RFC Part2 PATCH v3 11/26] KVM: X86: Extend struct kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a5702c8-a60a-7836-6eec-891a3c3e8ace@amd.com>
Date:   Wed, 13 Sep 2017 10:14:20 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...e.de>
Cc:     brijesh.singh@....com, linux-kernel@...r.kernel.org,
        x86@...nel.org, kvm@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Joerg Roedel <joro@...tes.org>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        \"Radim Krčmář\" <rkrcmar@...hat.com>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [RFC Part2 PATCH v3 11/26] KVM: X86: Extend struct kvm_arch to
 include SEV information



On 09/13/2017 08:37 AM, Borislav Petkov wrote:
...

>> +	return &kvm->arch.sev_info;
>> +}
>> +
>> +static inline void sev_set_active(struct kvm *kvm)
>> +{
>> +	to_sev_info(kvm)->active = true;
>> +}
> 
> Is this the accepted way to do this in KVM land or can you simply access
> all members directly:
> 
> 	kvm->arch.sev_info.<member>
> 
> Because I see stuff like that:
> 

Actually, I see both approaches used in svm.c but I am flexible to go with
either ways. lets wait for Paolo and Radim comments.

-Brijesh