linux-kernel - Re: [patch V2 25/29] lockup_detector: Implement init time detection of perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1709132004400.1874@nanos>
Date:   Wed, 13 Sep 2017 20:05:18 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Don Zickus <dzickus@...hat.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Nicholas Piggin <npiggin@...il.com>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Ulrich Obergfell <uobergfe@...hat.com>
Subject: Re: [patch V2 25/29] lockup_detector: Implement init time detection
 of perf

On Wed, 13 Sep 2017, Don Zickus wrote:
> > +/* Return 0, if a NMI watchdog is available. Error code otherwise */
> > +int __weak __init void watchdog_nmi_probe(void)
> 
> ^^^ compile error, can't have 'int' and 'void'.  Removing 'void' fixes it.

Yes, I know. I feel stupid because I'm 100% sure that I compiled it ....