linux-kernel - Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0747f21a-c245-e0c6-0f31-52be307d8544@android.com>
Date:   Wed, 13 Sep 2017 11:30:51 -0700
From:   Mark Salyzyn <salyzyn@...roid.com>
To:     Prarit Bhargava <prarit@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Jonathan Corbet <corbet@....net>, Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Christoffer Dall <cdall@...aro.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Joel Fernandes <joelaf@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Olof Johansson <olof@...om.net>,
        Josh Poimboeuf <jpoimboe@...hat.com>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 3/3 v11] printk: Add monotonic, boottime, and realtime
 timestamps

On 09/05/2017 05:06 AM, Prarit Bhargava wrote:
> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock
> timestamp to printk messages.  The local hardware clock loses time each
> day making it difficult to determine exactly when an issue has occurred in
> the kernel log, and making it difficult to determine how kernel and
> hardware issues relate to each other in real time.
>
> Make printk output different timestamps by adding options for no
> timestamp, the local hardware clock, the monotonic clock, the boottime
> clock, and the real clock.  Allow a user to pick one of the clocks by
> using the printk.time kernel parameter.  Output the type of clock in
> /sys/module/printk/parameters/time so userspace programs can interpret the
> timestamp.
>
> v2: Use peterz's suggested Kconfig options.  Merge patchset together.
> Fix i386 !CONFIG_PRINTK builds.
>
> v3: Fixed x86_64_defconfig. Added printk_time_type enum and
> printk_time_str for better output. Added BOOTTIME clock functionality.
>
> v4: Fix messages, add additional printk.time options, and fix configs.
>
> v5: Renaming of structures, and allow printk_time_set() to
> evaluate substrings of entries (eg: allow 'r', 'real', 'realtime').  From
> peterz, make fast functions return 0 until timekeeping is initialized
> (removes timekeeping_active & ktime_get_boot|real_log_ts() suggested by
>   tglx and adds ktime_get_real_offset()).  Switch to a function pointer
> for printk_get_ts() and reference fast functions.  Make timestamp_sources enum
> match choice options for CONFIG_PRINTK_TIME (adds PRINTK_TIME_UNDEFINED).
>
> v6: Define PRINTK_TIME_UNDEFINED for !CONFIG_PRINTK builds.  Separate
> timekeeping changes into separate patch.  Minor include file cleanup.
>
> v7: Add default case to printk_set_timestamp() and add PRINTK_TIME_DEBUG
> for users that want to set timestamp to different values during runtime.
> Add jstultz' Kconfig to avoid defconfig churn.
>
> v8: Add CONFIG_PRINTK_TIME_DEBUG to allow timestamp runtime switching.
> Rename PRINTK_TIME_DISABLE to PRINTK_TIME_DISABLED.  Rename
> printk_set_timestamp() to printk_set_ts_func().  Separate
> printk_set_ts_func() and printk_get_first_ts() portions.  Rename param
> functions.  Adjust configs, enum, and timestamp_sources_str to be 0-4.
> Add mention realtime clock is UTC in Documentation.
>
> v9: Fix typo.  Add __ktime_get_real_fast_ns_unsafe().
>
> v10: Remove time parameter restrictions.
>
Ack and unit tested on Backport to 4.9.

(you are missing the v11 respin comment, NBD)

-- Mark