linux-kernel - Re: [PATCH v8 18/18] RISC-V: Build Infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <mhng-13aa2008-e670-4dc0-aac6-a6fbaa8d6df1@palmer-si-x1c4>
Date:   Wed, 13 Sep 2017 13:18:16 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     peterz@...radead.org, tglx@...utronix.de, jason@...edaemon.net,
        marc.zyngier@....com, dmitriy@...-tech.org,
        yamada.masahiro@...ionext.com, mmarek@...e.com, albert@...ive.com,
        will.deacon@....com, boqun.feng@...il.com, oleg@...hat.com,
        mingo@...hat.com, daniel.lezcano@...aro.org,
        gregkh@...uxfoundation.org, jslaby@...e.com, davem@...emloft.net,
        mchehab@...nel.org, hverkuil@...all.nl, rdunlap@...radead.org,
        viro@...iv.linux.org.uk, mhiramat@...nel.org, fweisbec@...il.com,
        mcgrof@...nel.org, dledford@...hat.com, bart.vanassche@...disk.com,
        sstabellini@...nel.org, mpe@...erman.id.au,
        rmk+kernel@...linux.org.uk, paul.gortmaker@...driver.com,
        nicolas.dichtel@...nd.com, linux@...ck-us.net,
        heiko.carstens@...ibm.com, schwidefsky@...ibm.com,
        geert@...ux-m68k.org, akpm@...ux-foundation.org,
        andriy.shevchenko@...ux.intel.com, jiri@...lanox.com,
        vgupta@...opsys.com, airlied@...hat.com, jk@...abs.org,
        chris@...is-wilson.co.uk, Jason@...c4.com,
        paulmck@...ux.vnet.ibm.com, ncardwell@...gle.com,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        patches@...ups.riscv.org
Subject:     Re: [PATCH v8 18/18] RISC-V: Build Infrastructure

On Wed, 13 Sep 2017 09:06:03 PDT (-0700), Arnd Bergmann wrote:
> On Tue, Sep 12, 2017 at 11:57 PM, Palmer Dabbelt <palmer@...belt.com> wrote:
>> This patch contains all the build infrastructure that actually enables
>> the RISC-V port.  This includes Makefiles, linker scripts, and Kconfig
>> files.  It also contains the only top-level change, which adds RISC-V to
>> the list of architectures that need a sed run to produce the ARCH
>> variable when building locally.
>
>> diff --git a/arch/riscv/configs/freedom-u500_defconfig b/arch/riscv/configs/freedom-u500_defconfig
>> new file mode 100644
>> index 000000000000..b580dc5c8feb
>> --- /dev/null
>> +++ b/arch/riscv/configs/freedom-u500_defconfig
>> @@ -0,0 +1,52 @@
>> +CONFIG_DEFAULT_HOSTNAME="ucbvax"
>
> That probably shouldn't be in here or the other defconfig files.

I agree.

>> +# CONFIG_CROSS_MEMORY_ATTACH is not set
>> +# CONFIG_FHANDLE is not set
>> +CONFIG_NAMESPACES=y
>> +# CONFIG_SGETMASK_SYSCALL is not set
>> +CONFIG_EMBEDDED=y
>
> You have CONFIG_EMBEDDED set in all defconfig files,
> which is a bit odd, as the only effect of that is to let you
> turn off some options that you normally want for a usable
> system, (e.g. sysfs, blk_dev or file_locking).
>
> Is this intentional?

No.

> In my experience, having one defconfig per machine
> can quickly get out of hand as more hardware gets added.
> You could start out with just one defconfig that sets all
> the common options, and then use config-fragments to
> decide between 32-bit and 64-bit.

Makes sense.  I guess I hadn't really paid much attention to the defconfig
files, I kind of just inherited them.  I'll go through them and come up with
something sane for the v9.