linux-kernel - Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2017 14:58:23 -0700
From:   Joe Perches <joe@...ches.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, devel@...verdev.osuosl.org,
        daniel.baluta@...il.com, Himanshi Jain <himshijain.hj@...il.com>,
        Michael.Hennerich@...log.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, nick.desaulniers@...il.com,
        outreachy-kernel@...glegroups.com, pmeerw@...erw.net,
        knaack.h@....de, Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro

On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
> He was exagerating a bit to call it a "static checker" warning...

Not really.

False positives and false negatives exist in just about
every static
checker.

> It's just checkpatch.pl complaining about adding spaces around the -
> operator.

checkpatch is a brain-damaged by design static checker.
regexes can only be sensitive to patterns, not compiled code.

> The sysfs file has a hyphen in the middle.

Another option would be to use an underscore instead.