linux-kernel - Re: [PATCH] v4l-ioctl: Fix typo on v4l_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18372913.S0YZhg91k1@avalon>
Date:   Wed, 13 Sep 2017 08:35:49 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hansverk@...co.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Tiffany Lin <tiffany.lin@...iatek.com>,
        Wu-Cheng Li <wuchengli@...omium.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

Hi Ricardo,

Thank you for the patch.

On Friday, 8 September 2017 18:47:10 EEST Ricardo Ribalda Delgado wrote:
> max_width and max_height are swap with step_width and step_height.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
> 
> Since that this bug has been here for ever. I do not know if we should
> notify stable or not
> 
> I have also cut the lines to respect the 80 char limit
> 
>  drivers/media/v4l2-core/v4l2-ioctl.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
> b/drivers/media/v4l2-core/v4l2-ioctl.c index b60a6b0841d1..79614992ee21
> 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -730,9 +730,12 @@ static void v4l_print_frmsizeenum(const void *arg, bool
> write_only) break;
>  	case V4L2_FRMSIZE_TYPE_STEPWISE:
>  		pr_cont(", min=%ux%u, max=%ux%u, step=%ux%u\n",
> -				p->stepwise.min_width,  p->stepwise.min_height,
> -				p->stepwise.step_width, p->stepwise.step_height,
> -				p->stepwise.max_width,  p->stepwise.max_height);
> +				p->stepwise.min_width,
> +				p->stepwise.min_height,
> +				p->stepwise.max_width,
> +				p->stepwise.max_height,
> +				p->stepwise.step_width,
> +				p->stepwise.step_height);

If you fix the indentation as well (aligning p-> right after the '(') you 
could keep two arguments per line :-)

>  		break;
>  	case V4L2_FRMSIZE_TYPE_CONTINUOUS:
>  		/* fall through */


-- 
Regards,

Laurent Pinchart