linux-kernel - Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Sep 2017 09:57:52 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Lee Duncan <lduncan@...e.com>
Cc:     Khazhismel Kumykov <khazhy@...gle.com>, cleech@...hat.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        open-iscsi@...glegroups.com
Subject: Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

On Wed, Sep 13, 2017 at 05:09:03PM -0700, Lee Duncan wrote:
> On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote:
> > iscsi_session_teardown was the only user of this function. Function
> > currently is just short for iscsi_remove_session + iscsi_free_session.
> > 
> > Signed-off-by: Khazhismel Kumykov <khazhy@...gle.com>
> 
> Why is this needed? I dislike changes that don't fix anything.

The function has no more users left after patch 1, so why keep it bitrotting?

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850