linux-kernel - Re: [PATCH 1/1] Coccinelle: array_size: report even if include is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1709141320170.3185@hadrien>
Date:   Thu, 14 Sep 2017 13:21:13 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Jérémy Lefaure <jeremy.lefaure@....epita.fr>
cc:     Michal Marek <mmarek@...e.com>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>, cocci@...teme.lip6.fr,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Coccinelle: array_size: report even if include is
 missing



On Wed, 13 Sep 2017, Jérémy Lefaure wrote:

> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@....epita.fr>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

I guess that if the incude is missing, the person updating the code can
always add it.


> ---
>
> I have tested this patch in report mode on the file
> drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c which does not
> use ARRAY_SIZE and does not include linux/kernel.h.
>
>  scripts/coccinelle/misc/array_size.cocci | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
> index 6ec05710b017..09520f0941f0 100644
> --- a/scripts/coccinelle/misc/array_size.cocci
> +++ b/scripts/coccinelle/misc/array_size.cocci
> @@ -72,13 +72,13 @@ position p;
>   (sizeof(E)@p /sizeof(T))
>  )
>
> -@...ipt:python depends on i&&org@
> +@...ipt:python depends on org@
>  p << r.p;
>  @@
>
>  coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
>
> -@...ipt:python depends on i&&report@
> +@...ipt:python depends on report@
>  p << r.p;
>  @@
>
> --
> 2.14.1
>
>