linux-kernel - Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v677Ed4-iX6fkYEYZ1N9ZLKXfQQF2hhdbcbBCaB0-g174A@mail.gmail.com>
Date:   Thu, 14 Sep 2017 20:14:10 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Alexander Syring <alex@...ring.de>
Cc:     Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c

On Thu, Sep 14, 2017 at 8:05 PM, Alexander Syring <alex@...ring.de> wrote:
> When using cpufreq-dt with default govenor other than "performance"
> system freezes while booting.
> Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the
> problem.
>
> Tested on Cubietruck (A20).
>
> Fixes: c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
>
> Reported-by: Alexander Syring <alex@...ring.de>

You typically don't need this if you yourself are the reporter.

> Signed-off-by: Alexander Syring <alex@...ring.de>

Acked-by: Chen-Yu Tsai <wens@...e.org>

> ---
>  drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> index 286b0049b7b6..a48fde191c0a 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> @@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = {
>                 .hw.init        = CLK_HW_INIT_PARENTS("cpu",
>                                                       cpu_parents,
>                                                       &ccu_mux_ops,
> -                                                     CLK_IS_CRITICAL),
> +                                                     CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
>         }
>  };
>
> --
> 2.11.0
>