lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.20.1709141431050.3185@hadrien> Date: Thu, 14 Sep 2017 14:31:47 +0200 (CEST) From: Julia Lawall <julia.lawall@...6.fr> To: Srishti Sharma <srishtishar@...il.com> cc: gilad@...yossef.com, gregkh@...uxfoundation.org, linux-crypto@...r.kernel.org, driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: ccree: Use kcalloc instead of kzalloc On Thu, 14 Sep 2017, Srishti Sharma wrote: > Use kcalloc instead of kzalloc to check for overflow before > multiplication. Done using the following semantic patch by > coccinelle. > > http://coccinelle.lip6.fr/rules/kzalloc.cocci > > Signed-off-by: Srishti Sharma <srishtishar@...il.com> > --- > drivers/staging/ccree/ssi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c > index 0655658..65a0529 100644 > --- a/drivers/staging/ccree/ssi_sysfs.c > +++ b/drivers/staging/ccree/ssi_sysfs.c > @@ -376,7 +376,7 @@ static int sys_init_dir(struct sys_dir *sys_dir, struct ssi_drvdata *drvdata, > return -ENOMEM; > /* allocate memory for directory's attributes list */ > sys_dir->sys_dir_attr_list = > - kzalloc(sizeof(struct attribute *) * (num_of_attrs + 1), > + kcalloc((num_of_attrs + 1), sizeof(struct attribute *), You don't need the parentheses around the first argument. julia > GFP_KERNEL); > > if (!(sys_dir->sys_dir_attr_list)) { > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com. > To post to this group, send email to outreachy-kernel@...glegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505391353-4516-1-git-send-email-srishtishar%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >
Powered by blists - more mailing lists