linux-kernel - Re: [PATCH] staging: iio: ad7192: Use the dedicated reset function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c2f62f5-3a64-29a0-7bbf-8545173530f9@analog.com>
Date:   Thu, 14 Sep 2017 16:31:06 +0200
From:   Michael Hennerich <michael.hennerich@...log.com>
To:     Stefan Popa <stefan.popa@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <jic23@...nel.org>
CC:     Hartmut Knaack <knaack.h@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-iio@...r.kernel.org>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: iio: ad7192: Use the dedicated reset function

On 14.09.2017 15:50, Stefan Popa wrote:
> SPI host drivers can use DMA to transfer data, so the buffer should be properly allocated.
> Keeping it on the stack could cause an undefined behavior.
> 
> The dedicated reset function solves this issue.
> 
> Signed-off-by: Stefan Popa <stefan.popa@...log.com>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

Well done!


> ---
>   drivers/staging/iio/adc/ad7192.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index d11c6de..6150d27 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -223,11 +223,9 @@ static int ad7192_setup(struct ad7192_state *st,
>   	struct iio_dev *indio_dev = spi_get_drvdata(st->sd.spi);
>   	unsigned long long scale_uv;
>   	int i, ret, id;
> -	u8 ones[6];
>   
>   	/* reset the serial interface */
> -	memset(&ones, 0xFF, 6);
> -	ret = spi_write(st->sd.spi, &ones, 6);
> +	ret = ad_sd_reset(&st->sd, 48);
>   	if (ret < 0)
>   		goto out;
>   	usleep_range(500, 1000); /* Wait for at least 500us */
> 


-- 
Greetings,
Michael

--
Analog Devices GmbH      Otl-Aicher Strasse 60-64      80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne