linux-kernel - Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170914184949.enuziddz27polfyf@sirena.org.uk>
Date:   Thu, 14 Sep 2017 11:49:49 -0700
From:   Mark Brown <broonie@...nel.org>
To:     Ryan Lee <ryans.lee@...imintegrated.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        kuninori.morimoto.gx@...esas.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, ryan.lee.maxim@...il.com
Subject: Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B
 format

On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
> ---

Please make an effort to write changelogs that clearly describe the
change you're making.  This is doing way more than just implementing DSP
mode, it's also adding a fairly complicated set_tdm_slot() implementation 
which isn't mentioned at all.  It probably needs splitting into multiple
patches as well.

> @@ -414,6 +504,9 @@ static int max98927_dac_event(struct snd_soc_dapm_widget *w,
>  	struct max98927_priv *max98927 = snd_soc_codec_get_drvdata(codec);
>  
>  	switch (event) {
> +	case SND_SOC_DAPM_PRE_PMU:
> +		max98927->tdm_mode = 0;
> +		break;
>  	case SND_SOC_DAPM_POST_PMU:
>  		regmap_update_bits(max98927->regmap,
>  			MAX98927_R003A_AMP_EN,

Why is an event associated with the DAC changing something related to
the DAI format?  These things should be unrelated.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)