lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <34017292-5BDF-4218-8144-695088D12AF3@cmss.chinamobile.com> Date: Thu, 14 Sep 2017 14:19:20 +0800 From: 严海双 <yanhaishuang@...s.chinamobile.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Eric Dumazet <edumazet@...gle.com>, Luca BRUNO <lucab@...ian.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob > On 2017年9月13日, at 下午9:02, Eric Dumazet <eric.dumazet@...il.com> wrote: > > On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote: >> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote: >>> Different namespace application might require enable TCP Fast Open >>> feature independently of the host. >>> >> >> Poor changelog, no actual description / list of sysctls that are moved >> to per netns. >> >> And looking at the patch, it seems your conversion is not complete. >> >> So I will ask you to provide more evidence that you tested your patch >> next time you submit it. > > I suggest you move one sysctl at a time, in a patch series. > > It will be easier to document and test for you, and review for us. > > Thanks. > Okay, I will split my patch for each sysctl change. Thanks.
Powered by blists - more mailing lists