linux-kernel - Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170914063528.GB599@jagdpanzerIV.localdomain>
Date:   Thu, 14 Sep 2017 15:35:28 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     "Yu, Fenghua" <fenghua.yu@...el.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Helge Deller <deller@....de>,
        "Luck, Tony" <tony.luck@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Petr Mladek <pmladek@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier
 usages

Hi,

On (09/08/17 22:23), Yu, Fenghua wrote:
> > From: Sergey Senozhatsky [mailto:sergey.senozhatsky.work@...il.com]
> > On (09/07/17 16:05), Luck, Tony wrote:
> > +static inline bool __mod_text_address(struct module *mod,
> > +                                     unsigned long addr) {
> > +       /* Make sure it's within the text section. */
> > +       if (!within(addr, mod->init_layout.base, mod->init_layout.text_size)
> > +           && !within(addr, mod->core_layout.base, mod-
> > >core_layout.text_size))
> > +               return false;
> > +       return true;
> > +}
> 
> The __mod_text_address() may be defined only  on IA64, PPC64 and PARISC since it's only called in those cases.

sure. well, I didn't post the exact patch. __mod_text_address() was
supposed to be used from __module_text_address()  /* I factored out
__mod_text_address() from that function, basically */

---

@@ -4305,9 +4323,7 @@ struct module *__module_text_address(unsigned long addr)
 {
        struct module *mod = __module_address(addr);
        if (mod) {
-               /* Make sure it's within the text section. */
-               if (!within(addr, mod->init_layout.base, mod->init_layout.text_size)
-                   && !within(addr, mod->core_layout.base, mod->core_layout.text_size))
+               if (!__mod_text_address(mod, addr))
                        mod = NULL;
        }
        return mod;

---

	-ss