linux-kernel - Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2017 12:46:25 +0530 (IST)
From:   Fahad Kunnathadi <fahad.kunnathadi@...celdesigns.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     f fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
        Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org,
        soren brinkmann <soren.brinkmann@...inx.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter
 speed register.

Hi Andrew,

Thank you for review and comments.

I will review this driver code with any review comments before, and update you if I could find any..

Best Regards
Fahad K  

----- Original Message -----
From: "Andrew Lunn" <andrew@...n.ch>
To: "Fahad Kunnathadi" <fahad.kunnathadi@...celdesigns.com>
Cc: "f fainelli" <f.fainelli@...il.com>, netdev@...r.kernel.org, "Michal Simek" <michal.simek@...inx.com>, linux-kernel@...r.kernel.org, "soren brinkmann" <soren.brinkmann@...inx.com>, linux-arm-kernel@...ts.infradead.org
Sent: Thursday, September 14, 2017 8:04:54 PM
Subject: Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register.

On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote:
> To clear Speed Selection in MDIO control register(0x10),
> ie, clear bits 6 and 13 to zero while keeping other bits same.
> Before AND operation,The Mask value has to be perform with bitwise NOT
> operation (ie, ~ operator)
> 
> This patch clears current speed selection before writing the
> new speed settings to gmii2rgmii converter

Hi Fahad

I expect you will find other issues with this driver. I pointed some
out at the time it is submitted, but the developers went quiet as soon
as it was accepted.

Anyway, please ensure David Miller <davem@...emloft.net> gets a copy.

The subject line should be:

[PATCH net] net: phy: Fix mask value write on gmii2rgmii converter speed register.

and include a fixes tag:

Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support")

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew