linux-kernel - Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505460523.27581.5.camel@perches.com>
Date:   Fri, 15 Sep 2017 00:28:43 -0700
From:   Joe Perches <joe@...ches.com>
To:     Julia Lawall <julia.lawall@...6.fr>,
        Haneen Mohammed <hamohammed.sa@...il.com>
Cc:     outreachy-kernel <outreachy-kernel@...glegroups.com>,
        Mark Yao <mark.yao@...k-chips.com>,
        David Airlie <airlied@...ux.ie>,
        Heiko Stuebner <heiko@...ech.de>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        greg <gregkh@...uxfoundation.org>
Subject: Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_*
 with DRM_DEV_*

On Fri, 2017-09-15 at 08:58 +0200, Julia Lawall wrote:
> 
> On Fri, 15 Sep 2017, Haneen Mohammed wrote:
> 
> > This patch replace instances of dev_info/err/debug with
> > DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted
> > specific log messages. Issue corrected with the help of the following
> > Coccinelle script:
[]
> > @@ -935,7 +941,8 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder)
> >  		return;
> > 
> >  	if (clk_prepare_enable(dsi->pclk)) {
> > -		dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
> > +		DRM_DEV_ERROR(dsi->dev,
> > +			      "%s: Failed to enable pclk\n", __func__);

The uses of "%s: " ... , __func__ with DRM_DEV_ERROR
is redundant and should be removed.

> > @@ -967,7 +974,8 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder)
> >  		return;
> > 
> >  	if (clk_prepare_enable(dsi->pclk)) {
> > -		dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
> > +		DRM_DEV_ERROR(dsi->dev,
> > +			      "%s: Failed to enable pclk\n", __func__);

etc...