linux-kernel - [tip:core/urgent] objtool: Do not retrieve data from empty sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-7156b7141a037420a3cd99dbc1559e0235f57c07@git.kernel.org>
Date:   Fri, 15 Sep 2017 01:43:58 -0700
From:   tip-bot for Petr Vandrovec <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     dzickus@...hat.com, petr@...drovec.name, tglx@...utronix.de,
        jpoimboe@...hat.com, mingo@...nel.org, hpa@...or.com,
        peterz@...radead.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org
Subject: [tip:core/urgent] objtool: Do not retrieve data from empty sections

Commit-ID:  7156b7141a037420a3cd99dbc1559e0235f57c07
Gitweb:     http://git.kernel.org/tip/7156b7141a037420a3cd99dbc1559e0235f57c07
Author:     Petr Vandrovec <petr@...drovec.name>
AuthorDate: Fri, 15 Sep 2017 02:15:05 -0500
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 15 Sep 2017 10:30:31 +0200

objtool: Do not retrieve data from empty sections

Binutils 2.29-9 in Debian return an error when elf_getdata is invoked
on empty section (.note.GNU-stack in all kernel files), causing
immediate failure of kernel build with:

  elf_getdata: can't manipulate null section

As nothing is done with sections that have zero size, just do not
retrieve their data at all.

Signed-off-by: Petr Vandrovec <petr@...drovec.name>
Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
Reviewed-by: Don Zickus <dzickus@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/2ce30a44349065b70d0f00e71e286dc0cbe745e6.1505459652.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 tools/objtool/elf.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 1e89a5f..b4cd8bc 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -175,19 +175,20 @@ static int read_sections(struct elf *elf)
 			return -1;
 		}
 
-		sec->data = elf_getdata(s, NULL);
-		if (!sec->data) {
-			WARN_ELF("elf_getdata");
-			return -1;
-		}
-
-		if (sec->data->d_off != 0 ||
-		    sec->data->d_size != sec->sh.sh_size) {
-			WARN("unexpected data attributes for %s", sec->name);
-			return -1;
+		if (sec->sh.sh_size != 0) {
+			sec->data = elf_getdata(s, NULL);
+			if (!sec->data) {
+				WARN_ELF("elf_getdata");
+				return -1;
+			}
+			if (sec->data->d_off != 0 ||
+			    sec->data->d_size != sec->sh.sh_size) {
+				WARN("unexpected data attributes for %s",
+				     sec->name);
+				return -1;
+			}
 		}
-
-		sec->len = sec->data->d_size;
+		sec->len = sec->sh.sh_size;
 	}
 
 	/* sanity check, one more call to elf_nextscn() should return NULL */