linux-kernel - [tip:core/urgent] objtool: Fix memory leak in elf_create_rela

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-0998b7a0befdf6e734032895ee639a5e6f88cc3f@git.kernel.org>
Date:   Fri, 15 Sep 2017 02:36:48 -0700
From:   tip-bot for Martin Kepplinger <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, hpa@...or.com, martink@...teo.de,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        peterz@...radead.org, jpoimboe@...hat.com, mingo@...nel.org
Subject: [tip:core/urgent] objtool: Fix memory leak in
 elf_create_rela_section()

Commit-ID:  0998b7a0befdf6e734032895ee639a5e6f88cc3f
Gitweb:     http://git.kernel.org/tip/0998b7a0befdf6e734032895ee639a5e6f88cc3f
Author:     Martin Kepplinger <martink@...teo.de>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 15 Sep 2017 11:31:43 +0200

objtool: Fix memory leak in elf_create_rela_section()

Let's free the allocated char array 'relaname' before returning,
in order to avoid leaking memory.

Signed-off-by: Martin Kepplinger <martink@...teo.de>
Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: mingo.kernel.org@...il.com
Link: http://lkml.kernel.org/r/20170914060138.26472-1-martink@posteo.de
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980..1e89a5f 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+	free(relaname);
 	if (!sec)
 		return NULL;