linux-kernel - Re: [experimental PATCH] ovl: get rid of d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170915140734.GY5426@ZenIV.linux.org.uk>
Date:   Fri, 15 Sep 2017 15:07:34 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Miklos Szeredi <miklos@...redi.hu>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        "linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>
Subject: Re: [experimental PATCH] ovl: get rid of d_real()

On Fri, Sep 15, 2017 at 03:58:05PM +0200, Miklos Szeredi wrote:
> And here's the prototype.  Poof, d_real() is gone.
> 
> It definitely has got problems, but just maybe it can be made better than the
> current mess.  It *does* solve the ro-rw inconsistency for normal reads (not
> mmaps).

... and makes for mind-boggling amount of opening/closing the files on underlying
filesystem.  Doing that on sodding ->read_iter() is simply wrong.  And you are
using the wrong credentials for those opens, anyway - it should be creds of opener,
not reader.