linux-kernel - Re: [PATCH] livepatch: __klp_shadow_get_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170915142852.tzqi7w3ednwvhh54@redhat.com>
Date:   Fri, 15 Sep 2017 10:28:52 -0400
From:   Joe Lawrence <joe.lawrence@...hat.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to
 shadow.c

On Thu, Sep 14, 2017 at 02:15:36PM -0700, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
> 
> ... therefore make it static.
> 
> Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> ---
> 
> Sorry for not having spotted this before pushing out.
> 
>  kernel/livepatch/shadow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
> index 67e4360..fdac275 100644
> --- a/kernel/livepatch/shadow.c
> +++ b/kernel/livepatch/shadow.c
> @@ -113,7 +113,7 @@ void *klp_shadow_get(void *obj, unsigned long id)
>  }
>  EXPORT_SYMBOL_GPL(klp_shadow_get);
>  
> -void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> +static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
>  		       size_t size, gfp_t gfp_flags, bool warn_on_exist)
>  {
>  	struct klp_shadow *new_shadow;
> -- 
> 1.8.5.6

Acked-by: Joe Lawrence <joe.lawrence@...hat.com>

Thanks for cleaning this up, Jiri.

Also thanks to Miroslav, Petr, Nicolai and Josh for the patchset
reviews!

-- Joe