linux-kernel - Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RV1108 SoC compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12073627-41af-3480-6379-839e07f5e8f3@rock-chips.com>
Date:   Fri, 15 Sep 2017 09:49:11 +0800
From:   Caesar Wang <wxt@...k-chips.com>
To:     Rocky Hao <rocky.hao@...k-chips.com>
Cc:     rui.zhang@...el.com, edubezval@...il.com, heiko@...ech.de,
        robh+dt@...nel.org, mark.rutland@....com, catalin.marinas@....com,
        will.deacon@....com, huangtao@...k-chips.com,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        shawn.lin@...k-chips.com, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, cl@...k-chips.com,
        william.wu@...k-chips.com, jay.xu@...k-chips.com,
        xxx@...k-chips.com, linux-arm-kernel@...ts.infradead.org,
        wxt@...k-chips.com
Subject: Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RV1108 SoC
 compatible

Hi Rocky,

在 2017年08月24日 18:27, Rocky Hao 写道:
> Add a new compatible for thermal founding on RV1108 SoCs.
>
> Signed-off-by: Rocky Hao <rocky.hao@...k-chips.com>
> ---
>   Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> index e3a6234fb1ac..43d744e5305e 100644
> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> @@ -2,6 +2,7 @@
>   
>   Required properties:
>   - compatible : should be "rockchip,<name>-tsadc"
> +   "rockchip,rv1108-tsadc": found on RV1108 SoCs

According to the order,  we should put the string after the 
"rockchip,rk3399-tsadc"..., not here.
>      "rockchip,rk3228-tsadc": found on RK3228 SoCs
>      "rockchip,rk3288-tsadc": found on RK3288 SoCs
>      "rockchip,rk3328-tsadc": found on RK3328 SoCs