linux-kernel - Re: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170915184011.GR2016@tuxbook>
Date:   Fri, 15 Sep 2017 11:40:11 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Chris Lew <clew@...eaurora.org>
Cc:     andy.gross@...aro.org, david.brown@...aro.org,
        aneela@...eaurora.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit

On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote:

> In V12 SMEM, SBL writes SMEM parameter information
> after the TOC. Use the SBL provided item count
> as the max item number.

Please wrap your commit messages at 72 chars (50 for the subject).

[..]
> +static u32 qcom_smem_get_dynamic_item(struct qcom_smem *smem)

This naming is too similar to the functions for looking up items, please
rename it to "qcom_smem_get_item_count()".

Regards,
Bjorn