linux-kernel - Re: [PATCH] perf, tools: Improve error messages for missing PMUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170915190024.GD14469@kernel.org>
Date:   Fri, 15 Sep 2017 16:00:24 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
        jolsa@...nel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools: Improve error messages for missing PMUs

Em Fri, Sep 15, 2017 at 08:45:10PM +0200, Jiri Olsa escreveu:
> On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote:
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt,
> >  	memset(&parse_error, 0, sizeof(struct parse_events_error));
> >  	ret = parse_events(perf_evlist, extra_events.buf, &parse_error);
> >  	if (ret) {
> > -		pr_err("Cannot set up events %s\n", extra_events.buf);
> > +                parse_events_print_error(&parse_error, extra_events.buf);
> 
> nit, mixed tabs/spaces indent, other than that:

Fixed that.
 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks, applied.

- Arnaldo