linux-kernel - Re: [PATCH v2 4/5] watchdog: jz4740: Add support for the watchdog in jz4780 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170915224220.GB3420@roeck-us.net>
Date:   Fri, 15 Sep 2017 15:42:20 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        Wim Van Sebroeck <wim@...ana.be>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] watchdog: jz4740: Add support for the watchdog in
 jz4780 SoC

On Fri, Sep 15, 2017 at 09:20:19PM +0200, Mathieu Malaterre wrote:
> The watchdog unit present in the JZ4780 works the same as the one in the
> JZ4740.
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
> Changes in v2:
> * do not re-use the compatible string for different SoC (Paul Cercueil)

I thought that was one of the specific features of compatible statements,
to avoid having to change the driver each time a new chip comes along.
Did that change recently ?

Guenter

> 
>  drivers/watchdog/jz4740_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index 20627f22baf6..aafbeb96561b 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -146,6 +146,7 @@ static const struct watchdog_ops jz4740_wdt_ops = {
>  #ifdef CONFIG_OF
>  static const struct of_device_id jz4740_wdt_of_matches[] = {
>  	{ .compatible = "ingenic,jz4740-watchdog", },
> +	{ .compatible = "ingenic,jz4780-watchdog", },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches);
> -- 
> 2.11.0
>