lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1505455268.27581.3.camel@perches.com> Date: Thu, 14 Sep 2017 23:01:08 -0700 From: Joe Perches <joe@...ches.com> To: Miles Chen <miles.chen@...iatek.com>, Andy Whitcroft <apw@...onical.com>, Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, wsd_upstream@...iatek.com, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH v2] checkpatch: support function pointers for unnamed function definition arguments On Thu, 2017-09-14 at 19:52 +0800, Miles Chen wrote: > Current unnamed function definition argument does not include function > pointer cases and it reports something like: > > WARNING: function definition argument 'void' should also have an identifier name > +unsigned int (*dummy)(void); > > Support function pointers for unnamed function arguments > > Signed-off-by: Miles Chen <miles.chen@...iatek.com> Acked-by: Joe Perches <joe@...ches.com> > --- > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index dd2c262..03eb255 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -5957,7 +5957,7 @@ sub process { > > # check for function declarations that have arguments without identifier names > if (defined $stat && > - $stat =~ /^.\s*(?:extern\s+)?$Type\s*$Ident\s*\(\s*([^{]+)\s*\)\s*;/s && > + $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s && > $1 ne "void") { > my $args = trim($1); > while ($args =~ m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) {
Powered by blists - more mailing lists