linux-kernel - Re: [PATCH] iio: dac: ds4422/ds4424 dac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYDV-kS-VgvvssU4s6Hrg-5MQ5Xh3v3NNxZWMhAwDXxxQ@mail.gmail.com>
Date:   Fri, 15 Sep 2017 09:11:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ismail Kose <Ismail.Kose@...imintegrated.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Jean-Francois Dagenais <jeff.dagenais@...il.com>,
        Fabrice Gasnier <fabrice.gasnier@...com>,
        gwenhael.goavec-merou@...bucayre.com,
        Peter Rosin <peda@...ntia.se>,
        Maxime Roussin-Bélanger 
        <maxime.roussinbelanger@...il.com>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        "Ismail H. KOSE" <ihkose@...il.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: dac: ds4422/ds4424 dac driver

On Thu, Sep 14, 2017 at 10:24 PM, Ismail Kose
<Ismail.Kose@...imintegrated.com> wrote:

> +struct ds4424_pdata {
> +       const char *vcc_supply_name;

Should not be needed at all, get the supply directly from the device tree.

> +       uint32_t rfs_res[DS4424_MAX_DAC_CHANNELS];
> +       struct iio_map *dac_iio_map;
> +};

Drop this entire platform data file and move all these fields
you still need into struct ds4424_data.

If you have legacy kernels still using platform data, that's too
bad, we will not maintain them upstream and not merge new
board files using platform data normally, use device tree or ACPI
DSTD only please.

Yours,
Linus Walleij