lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 16 Sep 2017 19:19:34 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Srishti Sharma <srishtishar@...il.com>
cc:     lidza.louina@...il.com, markh@...pro.net,
        gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/2] Staging: dgnc: Remove unused
 fields in struct dgnc_board



On Sat, 16 Sep 2017, Srishti Sharma wrote:

> Remove unused fields and comments associated with them in
> the structure definition.
>
> Signed-off-by: Srishti Sharma <srishtishar@...il.com>

Acked-by: Julia Lawall <julia.lawall@...6.fr>

> ---
> Changes in v2:
>  - Use the word field instead of variable.
>
>  drivers/staging/dgnc/dgnc_driver.h | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 764d6fe..5d2566e 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -104,7 +104,6 @@ struct board_ops {
>   * struct dgnc_board - Per board information.
>   * @boardnum: Board number (0 - 32).
>   *
> - * @type: Type of board.
>   * @name: Product name.
>   * @pdev: Pointer to the pci_dev structure.
>   * @bd_flags: Board flags.
> @@ -140,13 +139,9 @@ struct board_ops {
>   * @dpastatus: Board status as defined by DPA.
>   * @bd_dividend: Board/UART's specific dividend.
>   * @bd_ops: Pointer to board operations structure.
> - * @proc_entry_pointer: Proc/<board> entry
> - * @dgnc_board_table: Proc/<board> entry
>   */
>  struct dgnc_board {
>  	int		boardnum;
> -
> -	int		type;
>  	char		*name;
>  	struct pci_dev	*pdev;
>  	unsigned long	bd_flags;
> @@ -200,10 +195,6 @@ struct dgnc_board {
>  	uint		bd_dividend;
>
>  	struct board_ops *bd_ops;
> -
> -	struct proc_dir_entry *proc_entry_pointer;
> -	struct dgnc_proc_entry *dgnc_board_table;
> -
>  };
>
>  /* Unit flag definitions for un_flags. */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/dd9a08aabab9cfc60a5c7c7c0d5191d72e68c2d2.1505579408.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Powered by blists - more mailing lists